Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_cloudfront_monitoring_subscription resource #18083

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Add aws_cloudfront_monitoring_subscription resource #18083

merged 6 commits into from
Jun 30, 2021

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Mar 14, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11577

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudFrontMonitoringSubscription_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontMonitoringSubscription_ -timeout 180m
=== RUN   TestAccAWSCloudFrontMonitoringSubscription_basic
=== PAUSE TestAccAWSCloudFrontMonitoringSubscription_basic
=== RUN   TestAccAWSCloudFrontMonitoringSubscription_disappears
=== PAUSE TestAccAWSCloudFrontMonitoringSubscription_disappears
=== RUN   TestAccAWSCloudFrontMonitoringSubscription_RealtimeMetricsSubscriptionConfig
=== PAUSE TestAccAWSCloudFrontMonitoringSubscription_RealtimeMetricsSubscriptionConfig
=== CONT  TestAccAWSCloudFrontMonitoringSubscription_basic
=== CONT  TestAccAWSCloudFrontMonitoringSubscription_RealtimeMetricsSubscriptionConfig
=== CONT  TestAccAWSCloudFrontMonitoringSubscription_disappears
--- PASS: TestAccAWSCloudFrontMonitoringSubscription_basic (390.68s)
--- PASS: TestAccAWSCloudFrontMonitoringSubscription_disappears (392.95s)
--- PASS: TestAccAWSCloudFrontMonitoringSubscription_RealtimeMetricsSubscriptionConfig (400.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	402.625s

Added aws_cloudfront_monitoring_subscription resource. Thank you for your review!

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Mar 14, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2021
@shuheiktgw shuheiktgw force-pushed the add_aws_cloudfront_monitoring_subscription_resource branch 2 times, most recently from af6ba11 to 9558c5e Compare March 14, 2021 11:41
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 14, 2021
@shuheiktgw shuheiktgw force-pushed the add_aws_cloudfront_monitoring_subscription_resource branch from 26dc1c0 to 244bacb Compare March 14, 2021 23:35
@shuheiktgw shuheiktgw marked this pull request as ready for review March 14, 2021 23:36
@shuheiktgw shuheiktgw requested a review from a team as a code owner March 14, 2021 23:36
@shuheiktgw shuheiktgw mentioned this pull request Mar 14, 2021
Closed
@bill-rich bill-rich force-pushed the add_aws_cloudfront_monitoring_subscription_resource branch from cdcfeec to c38fe52 Compare June 30, 2021 21:35
bill-rich
bill-rich approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontMonitoringSubscription_ -timeout 180m
=== RUN   TestAccAWSCloudFrontMonitoringSubscription_basic
=== PAUSE TestAccAWSCloudFrontMonitoringSubscription_basic
=== RUN   TestAccAWSCloudFrontMonitoringSubscription_disappears
=== PAUSE TestAccAWSCloudFrontMonitoringSubscription_disappears
=== RUN   TestAccAWSCloudFrontMonitoringSubscription_update
=== PAUSE TestAccAWSCloudFrontMonitoringSubscription_update
=== CONT  TestAccAWSCloudFrontMonitoringSubscription_basic
=== CONT  TestAccAWSCloudFrontMonitoringSubscription_update
=== CONT  TestAccAWSCloudFrontMonitoringSubscription_disappears
--- PASS: TestAccAWSCloudFrontMonitoringSubscription_disappears (371.08s)
--- PASS: TestAccAWSCloudFrontMonitoringSubscription_basic (371.72s)
--- PASS: TestAccAWSCloudFrontMonitoringSubscription_update (405.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	405.775s

@bill-rich bill-rich merged commit 97b02df into hashicorp:main Jun 30, 2021
@github-actions github-actions bot added this to the v3.48.0 milestone Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.48.0
Development

Successfully merging this pull request may close these issues.

Amazon CloudFront additional real-time metrics in Amazon CloudWatch
3 participants
@shuheiktgw @bill-rich @breathingdust